so I changed the icon PNG and now it say this when I try to add pull reqest
well I pretty sure I have a pull request
looks like you’re opening a pull request onto your own repo. if you’re trying to contribute to another repo, you need to open a pull request on the repo that you want the code to go into.
sorry but could you dumb down that pls
1 Like
@richard ?
is that correct @richard ?
that is correct, but i’m not sure your extension is currently at the quality level needed to be included in the default extensions list. that isn’t to say you can’t get it there! it’s just not there yet.
here’s some feedback:
i think your blocks are a little confusing right now. for example, let’s say i wanted to set the player’s icon so that they have 2.5 hearts left. right now i’d have to do that like this:
when really i would expect it to look more like this:
i also am not sure i understand the purpose of this block:
why would i ever want to set all of my icons to be half hearts? it seems like this block is just duplicating the functionality of the more general set vital icon to value block.
and some more random bits of feedback:
- the spacing blocks don’t seem to work with the attach blocks. same with the “arrange in rows” block
- the way you implemented attach is pretty inefficient, it will create a new forever thread every time this block is called and they’ll never get cleaned up (this is what is called a memory leak). consider creating one
on game updatecallback for your extension that updates all of the vital icons that the player has created at once - similarly, when you call destroy you are destroying all of the sprites but you aren’t removing their entries in the arrays you are maintaining in your extension. this is another memory leak
- creating multiple sprites is very inefficient. instead of creating one sprite for every icon in a status bar, consider creating one sprite that draws all icons in the bar at once. i would do this by making a new
classthat extendssprites.ExtendableSpriteand overrides thedrawmethod - I see you have a lot of markdown files in your repo that aren’t added in your pxt.json. those files won’t show up for the user when they right click on a block unless you add them to the files array and add a
//% help=""annotation on the block
2 Likes
@richard ok I’ll maybe get on that when I get some free time thank you but the set vitalicon to full and empty was just another way of doing it and the half was just for the idea of it like full empty and why not half also I don’t know how to use the class and to be honest if I have to kinda redo the whole thing I don’t know if I want also because some of my games for the arcade console I said I wanted to make use this and I don’t want to mess them up so
also @richard all though they create more than one sprite to be fair they don’t really do much just sit there so also I been thinking I kinda wanted my image letter extension on there a little more any way because I had less problems